Skip to content

🤖 Fix localized delete confirmations#1230

Merged
daveearley merged 1 commit into
HiEventsDev:developfrom
rayhan206:bugfix/issue-1220-localized-delete
Jul 1, 2026
Merged

🤖 Fix localized delete confirmations#1230
daveearley merged 1 commit into
HiEventsDev:developfrom
rayhan206:bugfix/issue-1220-localized-delete

Conversation

@rayhan206

Copy link
Copy Markdown
Contributor

Fixes #1220.

What changed

This updates the event and organizer danger-zone delete confirmations so the typed confirmation is compared against the same localized delete translation used by the input placeholder.

That means translated confirmation words such as German löschen can enable the delete button instead of requiring the English literal delete.

Validation

  • npm run build:csr passes
  • Targeted ESLint on the changed files reports no errors; existing warnings remain in those files
  • Full npm run lint currently fails on existing repository-wide lint errors unrelated to this patch
  • npm run build-strict:csr currently fails on existing repository-wide TypeScript errors unrelated to this patch

Notes

The same hardcoded confirmation pattern existed in both event deletion and organizer deletion, so both were updated for consistency.

@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@rayhan206

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@rayhan206 rayhan206 marked this pull request as ready for review June 29, 2026 21:04
@daveearley

Copy link
Copy Markdown
Contributor

Thanks @rayhan206

@daveearley daveearley merged commit 35913d4 into HiEventsDev:develop Jul 1, 2026
1 of 2 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛Delete event confirmation requires English "delete" instead of localized word

2 participants